Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update guidance on assets #4866

Merged

Conversation

lauraghiorghisor-tw
Copy link
Contributor

@lauraghiorghisor-tw lauraghiorghisor-tw commented Oct 30, 2024

@lauraghiorghisor-tw lauraghiorghisor-tw force-pushed the add-mention-of-replacements-on-deletion-section branch from 5fa5f80 to 76b72a9 Compare October 30, 2024 17:46
@lauraghiorghisor-tw lauraghiorghisor-tw force-pushed the add-mention-of-replacements-on-deletion-section branch 3 times, most recently from b75878a to 849d0d6 Compare December 11, 2024 09:43
@lauraghiorghisor-tw lauraghiorghisor-tw changed the title Add mention of replacements and redirects in asset deletion section Update guidance on assets Dec 11, 2024
source/manual/manage-assets.html.md.erb Outdated Show resolved Hide resolved
source/manual/manage-assets.html.md.erb Outdated Show resolved Hide resolved
source/manual/manage-assets.html.md.erb Outdated Show resolved Hide resolved
Copy link
Contributor

@ryanb-gds ryanb-gds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if the developer docs are quite the right place for some of this stuff - would probably be good to move the heavier stuff into the Asset Manager or Whitehall docs and then link to them from here. I feel the developer manuals are more aimed at "I want to quickly fix a problem without having to understand the whole of asset publishing, what do I do?"

source/manual/manage-assets.html.md.erb Outdated Show resolved Hide resolved
source/manual/manage-assets.html.md.erb Outdated Show resolved Hide resolved
source/manual/manage-assets.html.md.erb Outdated Show resolved Hide resolved
@lauraghiorghisor-tw
Copy link
Contributor Author

lauraghiorghisor-tw commented Dec 11, 2024

On the back of comments:

This is a temporary section. We are addressing the root cause of the bugs.
A data patch has also been run. Nonetheless, outliers might exist, that we
will tackle on 3rd line. This guidance can thus come in handy.

I thought about putting this in whitehall, but I feel like it best belongs here,
albeit at the bottom of the file.
Improve guidance, suggesting a less destructive fix for a broken asset.
Linking out to other sources and the whitehall bugs section below.

Update the removal in the originating publishing app guidance, as
we no longer advise developers to use the `delete_attachment` rake task.
We expect them to only delete assets in asset manager, unless they really
want to amend anything in the publishing app.
@lauraghiorghisor-tw lauraghiorghisor-tw force-pushed the add-mention-of-replacements-on-deletion-section branch from e9372bc to 08a4094 Compare December 16, 2024 17:34
Copy link
Contributor

@minhngocd minhngocd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thank you 🙏

@lauraghiorghisor-tw lauraghiorghisor-tw merged commit 4b9df59 into main Dec 17, 2024
5 checks passed
@lauraghiorghisor-tw lauraghiorghisor-tw deleted the add-mention-of-replacements-on-deletion-section branch December 17, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants